commit dc8d70908fb92c4c1f7a4051aecab51d2916903b Author: Gorka Eguileor Date: Mon Oct 5 22:00:59 2020 +0200 Backup: Fix formatting errors There are a couple of places in the Backup manager where we are passing a set instead of a dictionary to LOG.warning, which leads to an error: TypeError: not all arguments converted during string formatting This patch converts those sets into dicts, as they were intended. Closes-Bug: #1898621 Change-Id: I33c5ee005f23ed05bf93b9137000b28c3df7b7b2 diff --git a/cinder/backup/manager.py b/cinder/backup/manager.py index 05f2fa0..70a0ded 100644 --- a/cinder/backup/manager.py +++ b/cinder/backup/manager.py @@ -1023,7 +1023,7 @@ class BackupManager(manager.SchedulerDependentManager): LOG.warning("Failed to terminate the connection " "of volume %(volume_id)s, but it is " "acceptable.", - {'volume_id', volume.id}) + {'volume_id': volume.id}) def _attach_snapshot(self, ctxt, snapshot, properties): """Attach a snapshot.""" @@ -1041,7 +1041,7 @@ class BackupManager(manager.SchedulerDependentManager): LOG.warning("Failed to terminate the connection " "of snapshot %(snapshot_id)s, but it is " "acceptable.", - {'snapshot_id', snapshot.id}) + {'snapshot_id': snapshot.id}) def _connect_device(self, conn): """Establish connection to device."""