commit b79a25565d43912f173b9c51f18c178047672648 Author: Gal Paikin Date: Wed Oct 7 23:46:46 2020 +0300 Add a TODO to refactor ChangeNotesState and ChangeNotes There are some methods that are not used by the server, and could be refactored. Change-Id: I1102fe363a1c1628bbf7d5a03b988a87a8a48f47 diff --git a/java/com/google/gerrit/server/notedb/ChangeNotes.java b/java/com/google/gerrit/server/notedb/ChangeNotes.java index bd2e80c..890a1b1 100644 --- a/java/com/google/gerrit/server/notedb/ChangeNotes.java +++ b/java/com/google/gerrit/server/notedb/ChangeNotes.java @@ -77,6 +77,9 @@ import org.eclipse.jgit.lib.Ref; import org.eclipse.jgit.lib.Repository; /** View of a single {@link Change} based on the log of its notes branch. */ +// TODO(paiking): This class should be refactored to get rid of potentially duplicate or unneeded +// variables, such as allAttentionSetUpdates, reviewerUpdates, and others. + public class ChangeNotes extends AbstractChangeNotes { private static final FluentLogger logger = FluentLogger.forEnclosingClass(); diff --git a/java/com/google/gerrit/server/notedb/ChangeNotesState.java b/java/com/google/gerrit/server/notedb/ChangeNotesState.java index 98d6e6e..fa32686 100644 --- a/java/com/google/gerrit/server/notedb/ChangeNotesState.java +++ b/java/com/google/gerrit/server/notedb/ChangeNotesState.java @@ -84,6 +84,9 @@ import org.eclipse.jgit.lib.ObjectId; *

Note that {@link ChangeNotes} contains more than just a single {@code ChangeNoteState}, such * as per-draft information, so that class is not cached directly. */ +// TODO(paiking): This class should be refactored to get rid of potentially duplicate or unneeded +// variables, such as allAttentionSetUpdates, reviewerUpdates, and others. + @AutoValue public abstract class ChangeNotesState {