commit 9e9ec51dbeb1eeeec290eb1c4f5c912cdfa6a148 Author: Ben Rohlfs Date: Tue Oct 6 15:20:29 2020 +0200 Do not show attention related hovercard actions to guest users Bug: Issue 13427 Change-Id: I66279b92e8c591ef0524d81800f4166a7925f23c diff --git a/polygerrit-ui/app/elements/shared/gr-hovercard-account/gr-hovercard-account.ts b/polygerrit-ui/app/elements/shared/gr-hovercard-account/gr-hovercard-account.ts index 35fa015..f9e8800 100644 --- a/polygerrit-ui/app/elements/shared/gr-hovercard-account/gr-hovercard-account.ts +++ b/polygerrit-ui/app/elements/shared/gr-hovercard-account/gr-hovercard-account.ts @@ -132,11 +132,15 @@ export class GrHovercardAccount extends GestureEventListeners( } _computeShowActionAddToAttentionSet() { - return this.isAttentionEnabled && !this.hasUserAttention; + return ( + this._selfAccount && this.isAttentionEnabled && !this.hasUserAttention + ); } _computeShowActionRemoveFromAttentionSet() { - return this.isAttentionEnabled && this.hasUserAttention; + return ( + this._selfAccount && this.isAttentionEnabled && this.hasUserAttention + ); } _handleClickAddToAttentionSet() { diff --git a/polygerrit-ui/app/elements/shared/gr-hovercard-account/gr-hovercard-account_test.js b/polygerrit-ui/app/elements/shared/gr-hovercard-account/gr-hovercard-account_test.js index 6fd6c51..b3b9564 100644 --- a/polygerrit-ui/app/elements/shared/gr-hovercard-account/gr-hovercard-account_test.js +++ b/polygerrit-ui/app/elements/shared/gr-hovercard-account/gr-hovercard-account_test.js @@ -39,6 +39,7 @@ suite('gr-hovercard-account tests', () => { new Promise(resolve => { '2'; }) ); + element._selfAccount = {...ACCOUNT}; element.account = {...ACCOUNT}; element._config = { change: {enable_attention_set: true},